infosync: integrate PD HTTP client into the placement manager #48858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
adpot_client_to_info_syncer
branch
from
abbeeed to
db0349d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48858 +/- ##
=================================================
- Coverage 71.0184% 53.4758% -17.5426%
=================================================
Files 1366 1585 +219
Lines 404637 596869 +192232
=================================================
+ Hits 287367 319181 +31814
- Misses 97283 255200 +157917
- Partials 19987 22488 +2501
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7 tasks
JmPotato
commented
Nov 27, 2023
Comment on lines
-306
to
-316
| // Clone is used to duplicate a RuleOp for safe modification. | ||
| // Note that it is a shallow copy: Constraints is not cloned. | ||
| func (r *Rule) Clone() *Rule { | ||
| n := &Rule{} | ||
| *n = *r | ||
| return n | ||
| } | ||
|
|
||
| func (r *Rule) String() string { | ||
| return fmt.Sprintf("%+v", *r) | ||
| } |
There was a problem hiding this comment.
These two methods are implemented here now:
hawkingrei
approved these changes
Nov 27, 2023
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
adpot_client_to_info_syncer
branch
from
07205ee to
cf1b5cd
Compare
YuJuncen
approved these changes
Nov 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, YuJuncen, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #35319, tikv/pd#7300
Problem Summary:
Integrate PD HTTP client into the placement manager.
What is changed and how it works?
PlacementManagerwith PD HTTP client.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.